Not really sure if I should make a pull request or...
# netmaker
m
Not really sure if I should make a pull request or issue, but I ran into a few issues using the installing on FreeBSD (opnsense). The install script would fail to move the executable so that needed to be done manually after running it (it did succeed in download the correct one.). Then it needed to be re-run WITH the join key provided, not just the
VERSION
as the documents say.
j
A PR would be great!
m
Awesome! I've been looking for an excuse to contribute to something open source. I'll fix it and test it on a fresh opnsense install. Do you have any kind of workflows/test in place for this kind of thing? Anything in general I should consider? I've read the contributing guide. Also, should I make the changes to the docs as a separate pull request or put it all together?
j
would love to have a well-functioning flow for opnsense specifically. We only provide directions for FreeBSD generally.
we have unit tests you can run (go test ./...) that's about it. But sounds like this wouldn't be server side so probably not necessary
just make sure it works for your use case and we'll review
m
Sick, I'll get on that.