https://netmaker.org logo
Hi, I believe I've found the reason and have a fix...
# development
a
Hi, I believe I've found the reason and have a fix for the issues with an egress gateway behind a relay. Should I discuss that with anyone here first, or should I just go ahead and open a PR?
b
PR has already been merged
a
There's remaining issues with the egress gateway node itself getting routed out via the relay, as per my comment at https://github.com/gravitl/netmaker/issues/1269#issuecomment-1189749658
b
a
That one looks like it's for ingress, not egress?
b
you are correct
but egress behind relay works as far as I know
a
although I did just realise I was testing against master, not develop
I can repro the issues against the current develop branch, I just tried.
e.g.:
Copy code
[netclient] 2022-08-03 18:47:46 error running command: wg-quick up /etc/netclient/config/nm-test.conf
[netclient] 2022-08-03 18:47:46 [#] ip link add nm-test type wireguard
[#] wg setconf nm-test /dev/fd/63
[#] ip -4 address add 10.125.47.2 dev nm-test
[#] ip link set mtu 1280 up dev nm-test
[#] ip -4 route add 10.125.47.254/32 dev nm-test
[#] ip -4 route add 10.125.47.1/32 dev nm-test
[#] ip -4 route add 10.4.0.0/24 dev nm-test
RTNETLINK answers: File exists
b
PRs are welcome
a
So I'll just go ahead and make a PR with ... uhh...
bugfix_v0.14.7_relayed-egress
?
b
yes, that follows our naming convention
a
Ok, I'll go do that. Thanks.
b
your welcome and thanks for the PR
looks like the github deb mirrors are out of date again; could you run
go test ./...
in the root dir of your branch and add a comment regarding the tests into the PR
a
ah... that's a bit of a problem, I have this in a headless server and the tests are trying to include X11 headers
b
oh... ok
a
hold on, I've probably got a vm somewhere
got it
b
great thanks
17 Views